Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutating admission webhook and CRD #145

Open
worldtiki opened this issue Mar 4, 2021 · 0 comments
Open

Mutating admission webhook and CRD #145

worldtiki opened this issue Mar 4, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@worldtiki
Copy link
Collaborator

Describe the feature

Looking at the example in the documentation, most of the configs are just boilerplate to run Mittens than actual configs related to the warmup process.

image

This is actually worse if we add things like image pull secrets, resources, etc.

My proposal is to create a mutating admission webhook for Kubernetes that would react to a label (xyz-mittens-injection: true) and inject a Mittens sidecar when a new pod with this label is created.
The webhook would search for either a custom resource or a config map for that deployment where users would provide the flags required to run mittens (http requests, duration of the warmup, etc.) and use that information to inject the Mittens sidecar.

Rational

Reduce friction to adopt Mittens.

@worldtiki worldtiki added the enhancement New feature or request label Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant