Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feed route should not include type=public nor type=private #1072

Open
jennydaman opened this issue Feb 22, 2024 · 0 comments
Open

Feed route should not include type=public nor type=private #1072

jennydaman opened this issue Feb 22, 2024 · 0 comments

Comments

@jennydaman
Copy link
Collaborator

When sharing the URL to a feed, something like /feed/N will not work, the ChRIS_ui requires the URL to be in the form /feed/N?type=private or /feed/N?type=public.

Since whether the feed is public or private can be figured out by ChRIS_ui by requesting the feed from CUBE, this distinction shouldn't be part of the URI.

Related to FNNDSC/fnndsc#99
jennydaman added a commit to jennydaman/ChRIS_ui that referenced this issue Feb 28, 2024
@jennydaman
Add workaround for FNNDSC#1072
3a829a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jennydaman