Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using GRAPH.COPY in conjunction with MULTI/EXEC is unreliable #631

Open
JoonasC opened this issue Apr 12, 2024 · 2 comments
Open

Using GRAPH.COPY in conjunction with MULTI/EXEC is unreliable #631

JoonasC opened this issue Apr 12, 2024 · 2 comments

Comments

@JoonasC
Copy link

JoonasC commented Apr 12, 2024

This is related to PR FalkorDB/JFalkorDB#27, it seems that using GRAPH.COPY in conjunction with MULTI/EXEC is not reliable (Sometimes the graph gets copied properly and other times it doesn't). This causes a unit test in the aforementioned PR to sometimes fail and sometimes work.

@swilly22
Copy link
Contributor

Thank you @JoonasC for brining this to our attention, MULTI/EXEC doesn't play nicely with Falkor's consistency model and shouldn't be used with GRAPH commands, we'll consider removing MULTI/EXEC from Falkor's exposed Redis commands.

@JoonasC
Copy link
Author

JoonasC commented Apr 13, 2024

@swilly22 It would be problematic for me if MULTI/EXEC was removed, because I need to have some way to perform checks on a graph before I mutate it as I explained here: #502 (comment). Do you have an idea how I can do that without using MULTI/EXEC? One alternative would be pessimistic locking, but I would like to avoid it because it is more expensive than optimistic locking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants