Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WhenNoHandlerFound isn't triggered in all cases #284

Open
AlexeyRaga opened this issue Jul 1, 2022 · 4 comments
Open

WhenNoHandlerFound isn't triggered in all cases #284

AlexeyRaga opened this issue Jul 1, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@AlexeyRaga
Copy link

I am using KafkaFlow with SchemaRegistryAvroSerialiser.
I configure no handlers, and only WhenNoHandlerFound for the sake of an example.

When consumer gets the message and reads its schema from Schema Registry, tries to scan all the assemblies in the AppDomain to find a corresponding .NET type.

Then it has two choices:

  1. The type is found. In this case "no handler" action is fired correctly.
  2. Type is not found. This may happen when the consumer isn't aware of the message of a given schema and doesn't have a type for it, or if an assembly that contains this type isn't yet loaded into AppDomain. In this case the message seems to be just ignored and the "no handler" action is not triggered.

Expected behaviour: "No handler" action is triggered for any message that doesn't have a handler registered for it, regardless if the corresponding .NET type exists or not in the consumer's AppDomain.

@filipeesch filipeesch added the bug Something isn't working label Jul 21, 2022
@mhkolk
Copy link

mhkolk commented Apr 8, 2023

I can confirm this. Just spent a day debugging the custom type resolvers and handlers not getting called due to this issue and and due to the changes made in #342. The changes are being introduced into master too lightly.

@JoaoRodriguesGithub
Copy link
Contributor

Hi @AlexeyRaga,

Thank you for your contribution.

We are sorry to provide feedback just now.

Can you please consider update to the latest KafkaFlow version and check if the issue still persist?

We see this action valuable to pursue this topic in the near future.

@fuzolan
Copy link

fuzolan commented Mar 13, 2024

I just tested it with 3.0.4. It's still not triggering by type missmatch.

@JoaoRodriguesGithub
Copy link
Contributor

Hi @fuzolan,

Thank you for checking.

We are planning on addressing this ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

5 participants