Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix InstantSerializer ignoring the JsonFormat shape #242

Merged
merged 1 commit into from
Apr 30, 2022
Merged

Fix InstantSerializer ignoring the JsonFormat shape #242

merged 1 commit into from
Apr 30, 2022

Conversation

KaseiFR
Copy link
Contributor

@KaseiFR KaseiFR commented Apr 28, 2022

No description provided.

@KaseiFR KaseiFR mentioned this pull request Apr 28, 2022
Closed
@cowtowncoder
Copy link
Member

Looks good, added some minor comments.

One thing we do need -- if not already done -- is to get the CLA:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

it's a one-time thing, good for all contributions, so once we have it, no need to send again.

The usual method is to print CLA, fill & sign, scan/photo, email to info at fasterxml dot com.
Once we have it, I can proceed to merge this contribution.

Thank you again for submitting it!

@cowtowncoder
Copy link
Member

CLA received, merging.

@cowtowncoder cowtowncoder merged commit 9f0d023 into FasterXML:2.14 Apr 30, 2022
cowtowncoder added a commit that referenced this pull request Apr 30, 2022
@cowtowncoder
Add release notes for #242
3182a61
@cowtowncoder
Copy link
Member

Merged, thank you @KaseiFR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KaseiFR @cowtowncoder