Skip to content

Commit 916a5bc

Browse files
committed
Removed problematic exception handling.
1 parent 495d955 commit 916a5bc

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

src/main/java/dev/rilling/musicbrainzenricher/MusicbrainzEnricherApplication.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package dev.rilling.musicbrainzenricher;
22

3-
import dev.rilling.musicbrainzenricher.api.musicbrainz.MusicbrainzEditController;
43
import dev.rilling.musicbrainzenricher.core.DataType;
54
import org.jetbrains.annotations.NotNull;
65
import org.slf4j.Logger;
@@ -19,14 +18,10 @@ public class MusicbrainzEnricherApplication implements CommandLineRunner {
1918
private static final Logger LOGGER = LoggerFactory.getLogger(MusicbrainzEnricherApplication.class);
2019

2120
private final MusicbrainzEnricherService musicbrainzEnricherService;
22-
private final MusicbrainzEditController musicbrainzEditController;
2321
private final ExecutorService enrichmentExecutor;
2422

25-
MusicbrainzEnricherApplication(MusicbrainzEnricherService musicbrainzEnricherService,
26-
MusicbrainzEditController musicbrainzEditController,
27-
@Qualifier("enrichmentExecutor") ExecutorService enrichmentExecutor) {
23+
MusicbrainzEnricherApplication(MusicbrainzEnricherService musicbrainzEnricherService, @Qualifier("enrichmentExecutor") ExecutorService enrichmentExecutor) {
2824
this.musicbrainzEnricherService = musicbrainzEnricherService;
29-
this.musicbrainzEditController = musicbrainzEditController;
3025
this.enrichmentExecutor = enrichmentExecutor;
3126
}
3227

src/main/java/dev/rilling/musicbrainzenricher/MusicbrainzEnricherService.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,7 @@ public void runInSingleMode(@NotNull DataType dataType, @NotNull UUID mbid) {
4848

4949
private void executeEnrichment(@NotNull DataType dataType, @NotNull UUID mbid, AbstractEnrichmentService<?, ?> enrichmentService) {
5050
LOGGER.info("Starting enrichment for {} '{}'.", dataType, mbid);
51-
try {
52-
enrichmentService.executeEnrichment(mbid);
53-
} catch (RuntimeException e) {
54-
LOGGER.error("Could not enrich {} '{}'.", dataType, mbid, e);
55-
return;
56-
}
57-
// TODO: should not persist if submission was not flushed yet.
51+
enrichmentService.executeEnrichment(mbid);
5852
LOGGER.info("Completed enrichment for {} '{}'.", dataType, mbid);
5953
historyService.markAsChecked(dataType, mbid);
6054
}

0 commit comments

Comments
 (0)