Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate unit label code #105

Open
pvutov opened this issue Apr 13, 2020 · 0 comments
Open

Integrate unit label code #105

pvutov opened this issue Apr 13, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@pvutov
Copy link
Collaborator

pvutov commented Apr 13, 2020

DannyMcGee wrote us some unit label code but left it unfinished. To use the essential parts of it, I wrote the simple PlatoonLabel class and merged the code in commit dfac763.

The original code is still in the repo, unfinished and more complicated than our current implementation. The classes can trivially be removed, but they probably have features and design improvements that we can take over. The PlatoonLabel prefab also has a lot of stuff on it that is disabled and was originally to be used by that code. We should take over what makes sense and remove the rest.

The legacy classes/files are:
BackgroundBlur.shader
UnitLabelGFXController
ButtonGFXControl
UIGFXController
HealthBar
UIState
UIColors

@pvutov pvutov added the enhancement New feature or request label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant