Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prusaslicer Viewer 2.x doesnt recognize files processed by ArcWelder #52

Open
gdeconto opened this issue Feb 21, 2021 · 7 comments
Open

Comments

@gdeconto
Copy link

gdeconto commented Feb 21, 2021

This is more of an fyi or very minor issue, but the PrusaSlicer 2.x viewer expects a line that looks something like this at the top of the file:

; generated by PrusaSlicer 2.3.0+win64 on 2021-02-21 at 22:41:55 UTC

ArcWelder puts its own info (for example) at the top:

; Postprocessed by ArcWelder
; Copyright(C) 2020 - Brad Hochgesang
; resolution=0.05mm
; path_tolerance=5%
; max_radius=1000000.00mm
; default_xyz_precision=3
; default_e_precision=5

Even though they are just comments, this results in the viewer producing a popup error message stating:

"Internal error: Not a PrusaSlicer / Slic3r PE generated g-code"

It is a simple cut and paste fix for users, of course, but thought you should know.

Maybe the comments could be appended to the gcode file instead of prepending?

Very cool tool btw.

@FormerLurker
Copy link
Owner

I can just detect that comment and add it as the first line. However, that doesn't work for ultigcode, and since they wont print right without the first line comment, that will take precedence. Consider posting an issue to the PrusaSlicer github askint them to search the first N lines (maybe 100 or 1000) for their comments. If arcwelder can do this (and it does), PrusaSlicer can too.

@FormerLurker
Copy link
Owner

Also, just FYI, prusaslicer can't display g2/g3 commands.

@gdeconto
Copy link
Author

Also, just FYI, prusaslicer can't display g2/g3 commands.

there is an issue logged in github for this; prusa3d/PrusaSlicer#4352

@gdeconto
Copy link
Author

added new issue in github for the PrusaSlicer exception error issue; prusa3d/PrusaSlicer#6117

@FormerLurker
Copy link
Owner

Thanks for adding that issue! I'll try to tackle it on this end as well.

Also, regarding the issue you linked to above (4352), that is for adding arc generation to PrusaSlicer. I'm guessing they would fix visualization too in that case, but one could fix the rendering issue before adding native arc support.

@FormerLurker
Copy link
Owner

So, I tried forcing the prusa slicer comment to be the first line, but the viewer crashed. I think it just isn't capable of interpreting G2/G3 :(

Might be time to submit an issue on Prusa's github.

@gdeconto
Copy link
Author

So, I tried forcing the prusa slicer comment to be the first line, but the viewer crashed. I think it just isn't capable of interpreting G2/G3 :(

Might be time to submit an issue on Prusa's github.

already tried that myself with same results. looks like there is a commit that may fix this:

"enricoturri1966 added a commit that referenced this issue on Feb 24
@enricoturri1966
#6117 - Allow import of gcode files processed by ArcWelder"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants