Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Part]fix makeWireString for Win & Py > 3.09
- Loading branch information
1 parent
46b70c7
commit 3b29cf1
Showing
1 changed file
with
14 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b29cf1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be backported?
3b29cf1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3b29cf1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are conda builds for 3.10 I think
3b29cf1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3b29cf1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we risk anything by backporting? I would assume it's better to backport to the official branch so anyone that might need it can get the benefits rather than relying on downstream patching. I have no strong feeling on this so I won't be insisting on it, after all I don't compile on windows.
3b29cf1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.