Skip to content

Commit

Permalink
CMake: use system version of FindCoin3D.cmake
Browse files Browse the repository at this point in the history
  • Loading branch information
@wwmayer
wwmayer committed Jul 27, 2022
1 parent 39a4731 commit 7a198ca
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 125 deletions.
125 changes: 0 additions & 125 deletions cMake/FindCoin3D.cmake
View file

This file was deleted.

4 changes: 4 additions & 0 deletions cMake/FreeCAD_Helpers/SetupCoin3D.cmake
View file
Expand Up @@ -8,4 +8,8 @@ macro(SetupCoin3D)
"=================\n")
endif(NOT COIN3D_FOUND)

IF(NOT PIVY_VERSION)
execute_process (COMMAND ${Python3_EXECUTABLE} -c "import pivy as p; print(p.__version__,end='')" OUTPUT_VARIABLE PIVY_VERSION)
ENDIF()

endmacro(SetupCoin3D)

2 comments on commit 7a198ca

@J-Dunn
Copy link
Contributor

@J-Dunn J-Dunn commented on 7a198ca Aug 4, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now failing to find distro Coin3D+Coin3D-devel on Fedora 35. It does find a locally built Coin3D 4.0.1 installed from source.


-- Found SWIG: /bin/swig (found version "4.0.2")  
-- Found Eigen3: /usr/include/eigen3 (found suitable version "3.3.9", minimum required is "2.91.0") 
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Coin3D (missing: COIN3D_INCLUDE_DIRS)                                                                                                   
Call Stack (most recent call first):                                                                                                                     
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)                                                              
  /usr/share/cmake/Modules/FindCoin3D.cmake:75 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)                                                                       
  cMake/FreeCAD_Helpers/SetupCoin3D.cmake:9 (find_package)                                                                                               
  CMakeLists.txt:73 (SetupCoin3D)                                                                                                                        
                                                                                                                                                         
                                                                                                                                                         
-- Configuring incomplete, errors occurred!


dnf install Coin4-devel Coin4
...
RPM Fusion for Fedora 35 - Free tainted                                                                                   34 kB/s | 7.1 kB     00:00    
Package Coin4-devel-4.0.0-9.fc35.x86_64 is already installed.
Package Coin4-4.0.0-9.fc35.x86_64 is already installed.



ls /usr/include/Coin4
Inventor  SoDebug.h  SoWinEnterScope.h  SoWinLeaveScope.h

The only obvious difference I see between the distro and github versions the extra level Coin4:
/usr/local/include/Inventor
/usr/include/Coin4/Inventor

I guess this is throwing the standard cmake sniffer. Fedora often provide for concurrent installations of different package versions.

@J-Dunn
Copy link
Contributor

@J-Dunn J-Dunn commented on 7a198ca Aug 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the motivation for removing the FreeCAD cmake if it was working? Were there other issues?
Any suggestion what I need to do to get cmake to find the Fedora installation location in /usr/include/Coin4 ?

Please sign in to comment.