Skip to content

Commit

Permalink
Fem: remove the forced document recompute from ViewProviderFemPostSph…
Browse files Browse the repository at this point in the history
…ereFunction::updateData

This is already handled in ViewProviderFemPostFunction::dragFinishCallback and can be switched on or off.

See also: https://forum.freecadweb.org/viewtopic.php?p=584481#p584481
  • Loading branch information
wwmayer committed Apr 7, 2022
1 parent c4c0304 commit 82d5be5
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions src/Mod/Fem/Gui/ViewProviderFemPostFunction.cpp
Expand Up @@ -578,15 +578,6 @@ void ViewProviderFemPostSphereFunction::updateData(const App::Property* p) {
getManipulator()->setMatrix(t);
}
Gui::ViewProviderDocumentObject::updateData(p);

// after updating the geometry we must recompute

This comment has been minimized.

Copy link
@donovaly

donovaly Apr 8, 2022

Member

Thanks. After ickby's post I wanted to do the same but somehow lost track. (I would need more time for FC.)

// A sphere can be used by filters in other pipelines than the one the sphere is in.
// Therefore we must recompute the analysis, not only a single pipeline
if (p == &func->Center || p == &func->Radius) {
auto pcAnalysis = FemGui::ActiveAnalysisObserver::instance()->getActiveObject();
if (pcAnalysis)
pcAnalysis->recomputeFeature(true);
}
}

FunctionWidget* ViewProviderFemPostSphereFunction::createControlWidget() {
Expand Down

0 comments on commit 82d5be5

Please sign in to comment.