Skip to content

Commit

Permalink
[Gui] Always hide progress bar on finished load
Browse files Browse the repository at this point in the history
The loadFinished signal from QtWebEngine includes a boolean indicating
whether the load was "ssuccessful" or not, but no apparent way to
determine what error, if any, occurred. Given that we are never
displaying any error information to the user, hide the progress bar
regardless of the success or failure of the operation.
  • Loading branch information
chennes authored and wwmayer committed Oct 11, 2021
1 parent bce8c25 commit b01d0e5
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions src/Mod/Web/Gui/BrowserView.cpp
Expand Up @@ -693,12 +693,10 @@ void BrowserView::onLoadProgress(int step)

void BrowserView::onLoadFinished(bool ok)
{
if (ok) {
QProgressBar* bar = SequencerBar::instance()->getProgressBar();
bar->setValue(100);
bar->hide();
getMainWindow()->showMessage(QString());
}
QProgressBar* bar = SequencerBar::instance()->getProgressBar();
bar->setValue(100);
bar->hide();
getMainWindow()->showMessage(QString());
isLoading = false;
}

Expand Down

0 comments on commit b01d0e5

Please sign in to comment.