Arch: Fixed bug in precasts + addressing recursive wall length issue

FreeCAD · May 15, 2019 · b50ac86 · b50ac86
1 parent 96ee6fb
commit b50ac86
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/Mod/Arch/ArchPrecast.py b/src/Mod/Arch/ArchPrecast.py
@@ -74,7 +74,7 @@ def setProperties(self,obj):
     def onDocumentRestored(self,obj):
 
         ArchComponent.Component.onDocumentRestored(self,obj)
-        _Precast.onDocumentRestored(self,obj)
+        _Precast.setProperties(self,obj)
 
     def execute(self,obj):
 

diff --git a/src/Mod/Arch/ArchWall.py b/src/Mod/Arch/ArchWall.py
@@ -732,11 +732,17 @@ def execute(self,obj):
                             l = obj.Base.Shape.Length
                             if obj.Length.Value != l:
                                 obj.Length = l
+                                self.oldLength = None # delete the stored value to prevent triggering base change below
+
+    def onBeforeChange(self,obj,prop):
+
+        if prop == "Length":
+            self.oldLength = obj.Length.Value
 
     def onChanged(self,obj,prop):
 
         if prop == "Length":
-            if obj.Base and obj.Length.Value:
+            if obj.Base and obj.Length.Value and hasattr(self,"oldLength") and (self.oldLength != None) and (self.oldLength != obj.Length.Value):
                 if obj.Base.isDerivedFrom("Part::Feature"):
                     if len(obj.Base.Shape.Edges) == 1:
                         import DraftGeomUtils