Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking DEPENDS/IGNORE based on OSVERSION #381

Open
dlangille opened this issue Sep 7, 2022 · 5 comments
Open

Checking DEPENDS/IGNORE based on OSVERSION #381

dlangille opened this issue Sep 7, 2022 · 5 comments

Comments

@dlangille
Copy link
Contributor

dlangille commented Sep 7, 2022

Case in point: graphics/drm-kmod

$ make OSVERSION=1301000 -V RUN_DEPENDS 
/boot/modules/drm.ko:graphics/drm-fbsd13-kmod

$ make OSVERSION=1300000 -V RUN_DEPENDS 
gpu-firmware-kmod>=20220511:graphics/gpu-firmware-kmod

The RUN_DEPENDS varies depending upon which release you are running.

This would require:

  • The database does not have OSVERSION involved in DEPENDS - that table would need modification
  • What OSVERSION values get uses for this?
  • Where are they obtained from?
  • When new OSVERSION values come in, when do you start using them?
  • What do you do with old entries in the database?
  • If all the DEPENDS are the same for each OSVERSION, do you store a single set of values?

This could be applied to all DEPENDS: BUILD, LIB, RUN, etc.

It also applies to IGNORE, BROKEN.

This is not just adding another column to a table.

EDIT: This is not a priority for completion. There is a high work/risk/reward ratio.

@dlangille
Copy link
Contributor Author

Zirias said: another "solution" could be to add a disclaimer in your templates somewhere: "Freshports shows ports as seen on a 12.3-RELEASE system on amd64"

@dlangille
Copy link
Contributor Author

This affects:

  • about 137 ports which contain OSVERSION
  • 1045 ports referencing BROKEN
  • 464 ports referencing IGNORE

as found via grep -rl IGNORE * (for example).

This count doesn't try to figure out ports which get their values from other ports.

@dlangille
Copy link
Contributor Author

This also doesn't try to consider variations dependent upon ARCH

@dlangille
Copy link
Contributor Author

Let's say that's 1600 ports and that there are 38,000 ports.

This affects 4% of ports, roughly. Most definitely less because not ALL of the above indicate version specific instances.

@grahamperrin
Copy link
Contributor

Case in point: graphics/drm-kmod

For posterity:

In parallel, if I understand #398 (comment) correctly:

freebsd/freebsd-ports#140 and https://reviews.freebsd.org/D37672 are for a typo (and more) in the package description for graphics/drm-kmod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants