Allow Symfony 7 #3067
Open
Allow Symfony 7 #3067
+22
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoheinonen
commented
Dec 13, 2023
simoheinonen
commented
- fixes Allow Symfony 7 #3066
simoheinonen
force-pushed
the
sf7
branch
2 times, most recently
from
69c5a82
to
955a1db
Compare
stof
reviewed
Dec 13, 2023
.github/workflows/ci.yaml
Outdated
| @@ -26,6 +26,12 @@ jobs: | |||
| - description: 'Symfony 5.*' | |||
| php: '8.1' | |||
| symfony-versions: '^5.4' | |||
| - description: 'Symfony 6.*' | |||
| php: '8.1' | |||
| symfony-versions: '^6.3' | |||
.github/workflows/ci.yaml
Outdated
| symfony-versions: '^6.3' | ||
| - description: 'Symfony 7.*' | ||
| php: '8.2' | ||
| symfony-versions: '^7.0' |
There was a problem hiding this comment.
This job should be removed as we don't have a LTS version of Symfony 7 yet anyway. Symfony 7 will already be tested in the normal job for PHP 8.2 as that will be the compatible version.
| * @return void | ||
| */ | ||
| public function eraseCredentials() | ||
| public function eraseCredentials(): void |
There was a problem hiding this comment.
this is a BC break for child classes. If this is required to support Symfony 7, it means we will have to release it as a new major version (in which case we might want to first do a new minor version to ensure that we have the appropriate @return everywhere so that our new major version can switch to native return types everywhere)
|
Hi guys! Thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.