Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3C CSS Validator for options.css #83

Open
kniebremser opened this issue Jun 20, 2019 · 4 comments
Open

W3C CSS Validator for options.css #83

kniebremser opened this issue Jun 20, 2019 · 4 comments

Comments

@kniebremser
Copy link
Collaborator

unnecessary " } " in options/options.css was already available before my cleanup.

@Frumph
Copy link
Owner

Frumph commented Jun 20, 2019

that's alright but wouldn't cause the admin from not appearing

@kniebremser
Copy link
Collaborator Author

in line 548 and line 549 we each have the closing tag one is too much.
Can I delete one or it is on purpose.

@Frumph
Copy link
Owner

Frumph commented Jun 20, 2019

for some reason

https://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Ffrumph.net%2Fwp-content%2Fthemes%2Fcomicpress%2Foptions%2Foptions.css&profile=css3svg&usermedium=all&warning=1&vextwarning=&lang=en

doesn't have that extra } there .. .could it have been added by mistake on an update somewhere?

looking yeah .. it was added when someone 'updated colors' ;/ hehe so yeah if it doesn't belong of course get rid of it... i'm just waiting for you to finish what you're doing to update on repo ;)

@kniebremser
Copy link
Collaborator Author

I have removed the superfluous "}". After that, I was also the WPCS messages displayed. I have already fixed many of the messages.
In the style.css I have already made many mistakes. In the styl.css also worth this check.
I upload both files and then I'm done. Enough changed.

@kniebremser kniebremser changed the title unnecessary " } " in options/options.css W3C CSS Validator for css files Jul 14, 2019
@kniebremser kniebremser changed the title W3C CSS Validator for css files W3C CSS Validator for options.css Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants