Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Industrial Apiary Crashes with the Drainer #16222

Closed
3 tasks done
Alastors opened this issue May 9, 2024 · 0 comments · Fixed by GTNewHorizons/GT5-Unofficial#2596
Closed
3 tasks done

Industrial Apiary Crashes with the Drainer #16222

Alastors opened this issue May 9, 2024 · 0 comments · Fixed by GTNewHorizons/GT5-Unofficial#2596
Labels
Mod: Magic Bees Magic Bees related issues Type: bugMinor

Comments

@Alastors
Copy link
Member

Alastors commented May 9, 2024

Your GTNH Discord Username

Alastor

Your Pack Version

2.6.0

Your Server

Private

Java Version

Java 20

Type of Server

Don't know

Your Expectation

Not to crash

The Reality

https://discord.com/channels/181078474394566657/1029918255932002395/1237985684036386828
crash-2024-05-08_20.50.41-server.txt

Your Proposal

Fix it, I tried pushing a temp fix since I don't have time to skim a codebase I don't know well enough (for the industrial apiary) and was going to do it later since this needs to be in 2.5.1, but I'm not going to pull my hair out in the moment trying to figure out the actual cause on a holiday weekend.

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@Alastors Alastors added Type: bugMinor Status: Triage Tasks awaiting triage. Removed once a dev confirms the issue as valid. Mod: Magic Bees Magic Bees related issues and removed Status: Triage Tasks awaiting triage. Removed once a dev confirms the issue as valid. labels May 9, 2024
CromaMclos added a commit to CromaMclos/GT5-Unofficial that referenced this issue May 12, 2024
@CromaMclos
Update GT_MetaTileEntity_IndustrialApiary.java
f126740 
The Apimancer's Drainer uses GT_MetaTileEntity_IndustrialApiary.getUsedQueen to retrieve the queen currently being processed by the Industrial Apiary.

getUsedQueen is annotated with @SideOnly(Side.CLIENT) which only allows this function to be called from singleplayer. This function is not available when called from server-side and leads to the crash detailed in this issue.

As far as I can tell, this function has no reason to be singleplayer / client-side only. This seems to be an artifact from when this function was imported over 2 years ago.

Testing this change in our world prevents the crash and allows the Apimancer's Drainer to work as expected with the Industrial Apiary.

Resolves GTNewHorizons/GT-New-Horizons-Modpack#16222
@CromaMclos CromaMclos mentioned this issue May 12, 2024
Merged
Dream-Master pushed a commit to GTNewHorizons/GT5-Unofficial that referenced this issue May 12, 2024
@CromaMclos
Update GT_MetaTileEntity_IndustrialApiary.java (#2596)
569e4dc 
The Apimancer's Drainer uses GT_MetaTileEntity_IndustrialApiary.getUsedQueen to retrieve the queen currently being processed by the Industrial Apiary.

getUsedQueen is annotated with @SideOnly(Side.CLIENT) which only allows this function to be called from singleplayer. This function is not available when called from server-side and leads to the crash detailed in this issue.

As far as I can tell, this function has no reason to be singleplayer / client-side only. This seems to be an artifact from when this function was imported over 2 years ago.

Testing this change in our world prevents the crash and allows the Apimancer's Drainer to work as expected with the Industrial Apiary.

Resolves GTNewHorizons/GT-New-Horizons-Modpack#16222
Dream-Master pushed a commit to GTNewHorizons/GT5-Unofficial that referenced this issue May 19, 2024
@CromaMclos @Dream-Master
Update GT_MetaTileEntity_IndustrialApiary.java (#2596)
39fb127 
The Apimancer's Drainer uses GT_MetaTileEntity_IndustrialApiary.getUsedQueen to retrieve the queen currently being processed by the Industrial Apiary.

getUsedQueen is annotated with @SideOnly(Side.CLIENT) which only allows this function to be called from singleplayer. This function is not available when called from server-side and leads to the crash detailed in this issue.

As far as I can tell, this function has no reason to be singleplayer / client-side only. This seems to be an artifact from when this function was imported over 2 years ago.

Testing this change in our world prevents the crash and allows the Apimancer's Drainer to work as expected with the Industrial Apiary.

Resolves GTNewHorizons/GT-New-Horizons-Modpack#16222

(cherry picked from commit 569e4dc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Mod: Magic Bees Magic Bees related issues Type: bugMinor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update GT_MetaTileEntity_IndustrialApiary.java CromaMclos/GT5-Unofficial
1 participant
@Alastors