Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local: Disable submit button if placeholders are missing #1625

Open
trymebytes opened this issue May 10, 2023 · 1 comment
Open

Local: Disable submit button if placeholders are missing #1625

trymebytes opened this issue May 10, 2023 · 1 comment
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@trymebytes
Copy link
Contributor

trymebytes commented May 10, 2023

Right now, we show a list of placeholders required in a translation below the translation textarea. Placeholders missing from the translation entered in the textarea are highlighted in red while the placeholders included in the translation are highlighted in green color.

Can we disable the "Save translation" button if one or more of the placeholders are highlighted in red. This implies that user will not be able to submit a translation if a placeholder is missing from their translation.

Screenshot 2023-05-10 at 09 45 48

@trymebytes trymebytes created this issue from a note in Local GlotPress (To do) May 10, 2023
@amieiro amieiro added the [Type] Enhancement A suggestion for improvement. label Sep 30, 2023
@amieiro
Copy link
Member

amieiro commented Sep 30, 2023

I think this could be interesting for the main functionality too. I saw some problems with missing or incorrect placeholders.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
Development

No branches or pull requests

2 participants