Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error messages #1841

Open
amieiro opened this issue May 7, 2024 · 0 comments · May be fixed by #1842
Open

Improve the error messages #1841

amieiro opened this issue May 7, 2024 · 0 comments · May be fixed by #1842
Assignees
@amieiro
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@amieiro
Copy link
Member

amieiro commented May 7, 2024 •
edited

What problem does this address?

We should improve the error messages. Currently, the die_with_error method shows an empty page with the error text and the die_with_404 method shows a template that can be improved.

image

What is your proposed solution?

Add a template to the die_with_error method and improve the 404 template. Maybe we can use one template for all situations.

Related with WordPress/wporg-gp-translation-events#251.
@amieiro amieiro added the [Type] Enhancement A suggestion for improvement. label May 7, 2024
@amieiro amieiro self-assigned this May 7, 2024
@amieiro amieiro linked a pull request May 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amieiro amieiro

Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the 404 template and add a new generic error template amieiro/GlotPress
1 participant
@amieiro