Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking the number of variable while updating a fuzzy string #1843

Open
luisrull opened this issue May 8, 2024 · 1 comment
Open

Checking the number of variable while updating a fuzzy string #1843

luisrull opened this issue May 8, 2024 · 1 comment
Labels
[Type] Bug An existing feature is broken.

Comments

@luisrull
Copy link

luisrull commented May 8, 2024

Description

When a string is changed in a project and it's set to fuzzy state, if you approved the string and the new one has a variable and old one has it twice, GlotPress don't detect it, it goes to approved with the two variables when it should make a warning. I can br
The new string could be like
Get 20%% off with code **%s.** Hurry, offer ends 31 July.

and the old one that goes to approved without warning:

Consigue un 20%% de descuento con el código **%s en %s.** Date prisa, la oferta termina el 31 de julio.

(From https://translate.wordpress.org/projects/wp-plugins/all-in-one-wp-security-and-firewall/dev/es/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=15540336&filters%5Btranslation_id%5D=102919952)

Step-by-step reproduction instructions

Go to

https://translate.wordpress.org/projects/wp-plugins/all-in-one-wp-security-and-firewall/dev/es/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=15540336&filters%5Btranslation_id%5D=102919952

and Approve the string

Expected behavior

It should show a warning saying the variable %s should be once or that is wrong

Actual behavior

It goes to approved status

Screenshots or screen recording (optional)

WordPress information

  • WordPress version: N/A
  • GlotPress version: Not installed
  • Are all plugins except GlotPress deactivated? N/A
  • Are you using a default theme (e.g. Twenty Twenty-Three)? N/A

Device information

  • Operating system: macOS Sonoma 14.4.1
  • Browser: Firefox 125.0.3
@luisrull luisrull added the [Type] Bug An existing feature is broken. label May 8, 2024
@pedro-mendonca
Copy link
Member

@luisrull this is related to #1759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature is broken.
Projects
None yet
Development

No branches or pull requests

2 participants