Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseEntity.toPb method is not public #1431

Closed
vikkyrk opened this issue Nov 28, 2016 · 6 comments · Fixed by #5759
Closed

BaseEntity.toPb method is not public #1431

vikkyrk opened this issue Nov 28, 2016 · 6 comments · Fixed by #5759
Assignees
@yihanzhen
Labels
api: datastore Issues related to the Datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@vikkyrk
Copy link

vikkyrk commented Nov 28, 2016

There are cases where users want to convert com.google.cloud.datastore.Entity objects to native protobuf Entity objects (com.google.datastore.v1.Entity). For ex: while using Cloud Dataflow DatastoreIO, which only works with protobuf Entities. It would be nice to expose the toPb method by making it public.
@garrettjonesgoogle
Copy link
Member

Could you give a link to the code for Cloud Dataflow DatastoreIO?

@vikkyrk
Copy link
Author

vikkyrk commented Nov 30, 2016

@garrettjonesgoogle relevant files are here https://github.com/GoogleCloudPlatform/DataflowJavaSDK/tree/master/sdk/src/main/java/com/google/cloud/dataflow/sdk/io/datastore

@garrettjonesgoogle garrettjonesgoogle added api: datastore Issues related to the Datastore API. Extension in external code labels Dec 1, 2016
@garrettjonesgoogle garrettjonesgoogle added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed POST GA - P1 labels Apr 26, 2017
@garrettjonesgoogle garrettjonesgoogle added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jul 18, 2017
@anthmgoogle anthmgoogle added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Nov 9, 2017
@yihanzhen
Copy link
Contributor

The feature request is added to the backlog. The issue will be closed but is linked in the backlog and can continue to be used for comment and discussion.

@topecongiro
Copy link

@hzyi-google
What does it mean for the issue to be added to the backlog? Do maintainers of this SDK will accept a PR that fixes this issue? IMHO this will hugely benefit the DX of SDK users, as working with com.google.datastore.v1.Entity is very painful, especially when you try to create it manually for tests.

@topecongiro topecongiro mentioned this issue Jul 17, 2019
Merged
@yihanzhen
Copy link
Contributor

Please always feel free to send over a pull request :)

@chingor13 chingor13 reopened this Jul 19, 2019
@chingor13 chingor13 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. triaged for GA labels Jul 19, 2019
@jamesward
Copy link

Just a note for others running into it... toPb() was not made public in the associated PR. It was fromPb() that is now public. It'd be nice to have toPb() also public.

github-actions bot pushed a commit that referenced this issue Aug 9, 2022
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-pubsub to v1.12…
f909343 
…0.9 (#1431)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-pubsub](https://togithub.com/googleapis/java-pubsub) | `1.120.8` -> `1.120.9` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-pubsub/1.120.9/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-pubsub/1.120.9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-pubsub/1.120.9/compatibility-slim/1.120.8)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-pubsub/1.120.9/confidence-slim/1.120.8)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-pubsub</summary>

### [`v1.120.9`](https://togithub.com/googleapis/java-pubsub/blob/HEAD/CHANGELOG.md#&#8203;11209-httpsgithubcomgoogleapisjava-pubsubcomparev11208v11209-2022-08-03)

[Compare Source](https://togithub.com/googleapis/java-pubsub/compare/v1.120.8...v1.120.9)

##### Dependencies

-   update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#&#8203;1227](https://togithub.com/googleapis/java-pubsub/issues/1227)) ([e967b2c](https://togithub.com/googleapis/java-pubsub/commit/e967b2c393a601c7e9dfba33ec2f19ef6e9757c1))
-   update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.1 ([#&#8203;1226](https://togithub.com/googleapis/java-pubsub/issues/1226)) ([8fab566](https://togithub.com/googleapis/java-pubsub/commit/8fab566e2b0ff726bd9a1dff842b11f5c6c9b00b))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigquerydatatransfer).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNDEuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE0MS4wIn0=-->
github-actions bot pushed a commit that referenced this issue Aug 9, 2022
@release-please
chore(main): release 2.3.3 (#1437)
3733745 
🤖 I have created a release *beep* *boop*
---


## [2.3.3](googleapis/java-bigquerydatatransfer@v2.3.2...v2.3.3) (2022-08-09)


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v2.14.1 ([#1430](googleapis/java-bigquerydatatransfer#1430)) ([befed25](googleapis/java-bigquerydatatransfer@befed25))
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.2 ([#1433](googleapis/java-bigquerydatatransfer#1433)) ([30b6942](googleapis/java-bigquerydatatransfer@30b6942))
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.3 ([#1434](googleapis/java-bigquerydatatransfer#1434)) ([5c054b0](googleapis/java-bigquerydatatransfer@5c054b0))
* update dependency com.google.cloud:google-cloud-pubsub to v1.120.10 ([#1432](googleapis/java-bigquerydatatransfer#1432)) ([4ab39e9](googleapis/java-bigquerydatatransfer@4ab39e9))
* update dependency com.google.cloud:google-cloud-pubsub to v1.120.8 ([#1428](googleapis/java-bigquerydatatransfer#1428)) ([ddab51f](googleapis/java-bigquerydatatransfer@ddab51f))
* update dependency com.google.cloud:google-cloud-pubsub to v1.120.9 ([#1431](googleapis/java-bigquerydatatransfer#1431)) ([f909343](googleapis/java-bigquerydatatransfer@f909343))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#1426](googleapis/java-bigquerydatatransfer#1426)) ([8a2c31e](googleapis/java-bigquerydatatransfer@8a2c31e))
* update dependency com.google.protobuf:protobuf-java-util to v3.21.3 ([#1423](googleapis/java-bigquerydatatransfer#1423)) ([50bc04e](googleapis/java-bigquerydatatransfer@50bc04e))
* update dependency com.google.protobuf:protobuf-java-util to v3.21.4 ([#1425](googleapis/java-bigquerydatatransfer#1425)) ([60d8c78](googleapis/java-bigquerydatatransfer@60d8c78))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yihanzhen yihanzhen

Labels
api: datastore Issues related to the Datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose FullEntity::fromPb and Value::fromPb topecongiro/google-cloud-java
9 participants
@chingor13 @jamesward @vikkyrk @lesv @shinfan @anthmgoogle @garrettjonesgoogle @topecongiro @yihanzhen