Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the v1 API #7018

Closed
bgrant0607 opened this issue Apr 18, 2015 · 54 comments
Closed

Create the v1 API #7018

bgrant0607 opened this issue Apr 18, 2015 · 54 comments
Assignees
Labels
area/api Indicates an issue on api area. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Milestone

Comments

@bgrant0607
Copy link
Member

We're still finishing loose ends on v1beta3, but we need to clone it into the v1 API soon, and stop making breaking changes to v1beta3. As with v1beta3, v1 shouldn't be exposed by default and shouldn't be the latest API version until we freeze it.

@bgrant0607 bgrant0607 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/api Indicates an issue on api area. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Apr 18, 2015
@bgrant0607 bgrant0607 added this to the v1.0 milestone Apr 18, 2015
@thockin
Copy link
Member

thockin commented Apr 20, 2015

Do we have a list of candidate changes for v1 as compared to v1b3?

On Fri, Apr 17, 2015 at 8:27 PM, Brian Grant notifications@github.com
wrote:

We're still finishing loose ends on v1beta3, but we need to clone it into
the v1 API soon, and stop making breaking changes to v1beta3. As with
v1beta3, v1 shouldn't be exposed by default and shouldn't be the latest API
version until we freeze it.


Reply to this email directly or view it on GitHub
#7018.

@bgrant0607
Copy link
Member Author

Mostly this is intended to be a rename of the API.

Possible changes:

@thockin
Copy link
Member

thockin commented Apr 20, 2015

Can I add "make some optional fields into pointers for clearer denotation" ?

I am torn on volume sources. I am reviewing PV stuff still, I am just
nervous about how new it is..

On Mon, Apr 20, 2015 at 9:34 AM, Brian Grant notifications@github.com
wrote:

Mostly this is intended to be a rename of the API.

Possible changes:


Reply to this email directly or view it on GitHub
#7018 (comment)
.

@derekwaynecarr
Copy link
Member

I would like to see us support

delete /namespace/foo/pods

This would delete all pods in namespace foo.

It would literally delete the folder node that contained all pods in that namespace in etcd.

@bgrant0607
Copy link
Member Author

Maybe another pass on /componentstatuses, which was prematurely merged #6597.

@bgrant0607
Copy link
Member Author

We shouldn't need to wait until v1 in order to change the Go structs.

@thockin
Copy link
Member

thockin commented Apr 20, 2015

I was specifically thinking about #6735 which would change the default
value of replication controller.

On Mon, Apr 20, 2015 at 4:25 PM, Brian Grant notifications@github.com
wrote:

We shouldn't need to wait until v1 in order to change the Go structs.


Reply to this email directly or view it on GitHub
#7018 (comment)
.

@bgrant0607
Copy link
Member Author

Ah right, default of 1 replica rather than 0 replicas.

There's also the issue of changing the default cleanup behavior of replication controllers, as discussed in #1535 (comment)

@bgrant0607
Copy link
Member Author

Deduplication of SecurityContext-related fields (#6287) in Pod. cc @erictune

@nikhiljindal nikhiljindal self-assigned this Apr 27, 2015
@bgrant0607
Copy link
Member Author

StatusDetails ID field should be name: #7333

@thockin
Copy link
Member

thockin commented Apr 27, 2015

ServiceStatus should have a Phase

On Mon, Apr 27, 2015 at 4:19 PM, Brian Grant notifications@github.com
wrote:

StatusDetails ID field should be name: #7333
#7333


Reply to this email directly or view it on GitHub
#7018 (comment)
.

@bgrant0607
Copy link
Member Author

Or nothing should have a Phase. :-)

@bgrant0607
Copy link
Member Author

As suggested in #6910, perhaps we should eliminate the term "portal".

@thockin
Copy link
Member

thockin commented Apr 28, 2015

VIP ? But it might not always be Virtual - you could imagine an "internal"
load balancer that worked better - HAProxy or something - and using real
IPs. Just IP, maybe?

On Mon, Apr 27, 2015 at 7:40 PM, Brian Grant notifications@github.com
wrote:

As suggested in #6910
#6910, perhaps
we should eliminate the term "portal".


Reply to this email directly or view it on GitHub
#7018 (comment)
.

@thockin
Copy link
Member

thockin commented Apr 28, 2015

#6979 proposes rejiggering some of the named-one-of fields. better API, but requires cusotm JSON unmarshalling code.

@bgrant0607
Copy link
Member Author

Another possible issue: expanded image spec: #7203

@bgrant0607
Copy link
Member Author

api.Pod.Host vs. Node: #6895

@bgrant0607
Copy link
Member Author

Generalized label selectors: #7053 / #341

@bgrant0607
Copy link
Member Author

Created a new issue for replacement of phase with condition: #7856.

@bgrant0607
Copy link
Member Author

Clarification: Replacement of phase is almost certainly out for v1. I just referenced it for completeness.

@bgrant0607
Copy link
Member Author

We might want to reconsider use of ObjectReference in the API.

For cases in object specs where kind, namespace, and api version are fixed and where uid, resource version, etc. aren't supported for stronger consistency, it's simpler to just specify an object name.

I still feel that ObjectReference is probably easier for clients to deal with generically when comprehending objects, though, so we should use it in status, where necessary.

Current fields in specs:

Names: PodSpec.Host, PersistentVolumeClaimVolumeSource.ClaimName, GlusterfsVolumeSource.EndpointsName, SecretVolumeSource.SecretName, PodSpec.ServiceAccount

ObjectReference: PersistentVolumeSpec.ClaimRef, ServiceAccount.Secrets, PodSpec.PullSecrets, ReplicationControllerSpec.TemplateRef, Binding.Target, EnvVarSource.FieldRef (subset)

@bgrant0607 bgrant0607 mentioned this issue May 6, 2015
7 tasks
@alex-mohr alex-mohr added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 5, 2015
@bgrant0607
Copy link
Member Author

v1 is enabled by default, is the preferred API version, and is tested as much as v1beta3.

Docs/examples are covered by #9286.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue on api area. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests