Fix AWS region vs zone #6011
Merged
Fix AWS region vs zone #6011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,27 +29,50 @@ import ( | |||
| ) | |||
|
|
|||
| func TestReadAWSCloudConfig(t *testing.T) { | |||
| _, err1 := readAWSCloudConfig(nil) | |||
| _, err1 := readAWSCloudConfig(nil, nil) | |||
| if err1 == nil { | |||
| t.Errorf("Should error when no config reader is given") | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Is there a reason this isn't a table driven test?
We were specifying a region, but naming it as a zone in util.sh The zone matters just as much as the region, e.g. for EBS volumes. We also change the config to require a Zone, not a Region. But we fallback to get the information from the metadata service.
justinsb
force-pushed
the
aws_specify_zone
branch
from
2620599
to
583892d
Compare
|
Converted the two tests I touched to be table-driven. |
|
Ping |
|
Apologies. I should scan my PR queue. :/ |
|
LGTM. |
|
Thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were specifying a region, but naming it as a zone in util.sh
The zone matters just as much as the region, e.g. for EBS volumes.
We also change the config to require a Zone, not a Region.
But we fallback to get the information from the metadata service.