Parallelize architectures in both the building and packaging phases of make release
#6196
Conversation
|
cc @filbranden for bash fun |
|
Assigning to @ixdy, feel free to re-assign. |
zmerlynn
force-pushed
the
parallel_arch
branch
2 times, most recently
from
3d48d13
to
45bd335
Compare
|
@ixdy: Rebased, sorry, didn't see that I got sliced yesterday. |
|
Could you perhaps generate a more succint diff for review? It seems like most of this is formatting changes - it's difficult to work our what has actually changed. |
|
LGTM. Not sure if @filbranden has any shell commentary. |
|
@quinton-hoole: Not really, no. There was a tabbing change because of the sub-shell addition, which causes a large drift. |
|
Apologies for the delay. There are now merge conflicts. Please rebase and I'll merge. |
On my desktop, this took the KUBE_RELEASE_RUN_TESTS=n "make release" down from 172s to 115s
|
@quinton-hoole: PTAL. The rebase basically forced me to redo golang.sh, so I gave you two commits that are slightly more reviewable for that file (one commit that has the changes, the next that re-tab-ifies the middle block.) |
Parallelize architectures in both the building and packaging phases of `make release`
ghost
merged commit 
|
Awesome! |
|
I'm actually rolling this back due to #6346. I played with it for a while, and a have a working version that breaks based on the memory, but I'm now not sure the timing matters much. |
On my desktop, this took the KUBE_RELEASE_RUN_TESTS=n "make release" down from 172s to 115s.