defaults_tests: verify defaults when converting to an API object #6235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change verifies that defaults are applied after decoding an versioned object into an API object.
|
/cc @thockin |
|
Thanks! But you seem to have a change in there that is unrelated - please look at the diff. |
|
Nope, the lack of HostNetwork in api.ContainerManifest is causing the tests to fail. Note that HostNetwork is there in all versioned ContainerManifests. |
thockin
added a commit
that referenced
this pull request
Mar 31, 2015
defaults_tests: verify defaults when converting to an API object
atwamahmoud
added a commit
to atwamahmoud/kubernetes
that referenced
this pull request
Nov 8, 2023
… to be in line with kubernetes#6235
atwamahmoud
added a commit
to atwamahmoud/kubernetes
that referenced
this pull request
Jan 10, 2024
… to be in line with kubernetes#6235
atwamahmoud
added a commit
to atwamahmoud/kubernetes
that referenced
this pull request
Jan 10, 2024
… to be in line with kubernetes#6235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change verifies that defaults are applied after decoding an versioned
object into an API object.
This addresses the test issues in #6210