kubelet/fake_docker_client: Use self's PID instead of 42 in testing. #6653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is safer to use self's PID than some arbitrary PID (say 42), since the kubelet will set the oom_score_adj for real.
|
What's the problem you are trying to solve here? validate the oom_score_adj value? |
|
@dchen1107 Just found this on my way of fixing tests for #6608 |
|
Why is os.Getpid() better than 42? |
|
@lavalamp Hmm, PID 42 is some other process on my machine. Getpid() is just the test process. |
|
OK, I guess it doesn't make a difference to me. LGTM |
lavalamp
added a commit
that referenced
this pull request
Apr 9, 2015
kubelet/fake_docker_client: Use self's PID instead of 42 in testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is safer to use self's PID than some arbitrary PID (say 42),
since the kubelet will set the oom_score_adj for real in
kubelet.createPodInfraContainer.https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/kubelet/kubelet.go#L929
We can get rid of this in the future once we make the docker runtime to create pod infra container (thus we can add a stub in the fake docker)
Thanks!
@vmarmol @yujuhong