Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotate required flags for bash_completions #7076

Merged

Conversation

eparis
Copy link
Contributor

@eparis eparis commented Apr 20, 2015

some commands require that certain flags be set in order to function.
Annotate those flags so the bash completions will suggest to the user
that they be set.

some commands require that certain flags be set in order to function.
Annotate those flags so the bash completions will suggest to the user
that they be set.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@fgrzadkowski
Copy link
Contributor

lgtm

@fgrzadkowski
Copy link
Contributor

I think that shippable failure is just a flake, but can you please take a look?

@eparis eparis added cla: yes and removed cla: no labels Apr 28, 2015
@eparis
Copy link
Contributor Author

eparis commented Apr 30, 2015

shippable is clean....

@googlebot
Copy link

CLAs look good, thanks!

fgrzadkowski added a commit that referenced this pull request May 4, 2015
annotate required flags for bash_completions
@fgrzadkowski fgrzadkowski merged commit be2b246 into kubernetes:master May 4, 2015
@eparis eparis deleted the bash-5-kubectl-required-flags branch August 4, 2015 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants