Convert Elasticsearch logging to v1beta3 and de-salt #7246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satnam6502
changed the title
|
Have no idea about the salt changes. |
|
Well the de-salt can't have been that bad since I've been able to bring up several functioning clusters with this change. |
nikhiljindal
added
the
lgtm
nikhiljindal
added a commit
that referenced
this pull request
Apr 24, 2015
Convert Elasticsearch logging to v1beta3 and de-salt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zmerlynn note the change to the salt config to remove the number of Elasticsearch replicas.
I intend at a later stage to perhaps add this feature back in (but in a slightly different way) so I've left some aspects of the salt config sill in the code.