logs for master components #7316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +47,8 @@ | |||
| {% endif -%} | |||
| {% endif -%} | |||
|
|
|||
| {% set params = "--master=127.0.0.1:8080" + " " + machines + " " + cluster_name + " " + minion_regexp + " " + cloud_provider + " " + sync_nodes + " " + cloud_config + " " + pillar['log_level'] -%} | |||
There was a problem hiding this comment.
why --master=127.0.0.1:8080 required for logging kube-controller-manager?
There was a problem hiding this comment.
we always had --master=127.0.0.1:8080. check linke 62 of the checked in version (on left side).
|
Can you rebase first, then run e2e test for this? |
ArtfulCoder
force-pushed
the
master_components_logs
branch
from
992ae01
to
96439b5
Compare
|
rebased and ran e2e. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs from kube-controller-manager, kube-apiserver and kube-scheduler pods are written to corresponding /var/log files