Explicitly state the lack of support for 'Requests' for the purposes of scheduling #7443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -603,6 +603,8 @@ type ResourceRequirements struct { | |||
| // Limits describes the maximum amount of compute resources required. | |||
| Limits ResourceList `json:"limits,omitempty" description:"Maximum amount of compute resources allowed"` | |||
| // Requests describes the minimum amount of compute resources required. | |||
| // Note: 'Requests' are honored only for Persistent Volumes as of now. | |||
| // TODO: Update the scheduler to use 'Requests' instead of 'Limits' for the purposes of scheduling. | |||
There was a problem hiding this comment.
Would be useful to put this in all types.go files, and also in the description tag.
There was a problem hiding this comment.
Align the TODO with the resources.md document:
TODO: Update the scheduler to use Requests in addition to Limits. "If Request is omitted for a container, it defaults to Limits if that is explicitly specified, otherwise to an implementation-defined value"
|
PTAL |
|
Lgtm |
|
LGTM |
bgrant0607
added
the
lgtm
|
Now that we have, api/v1/types.go, can you please update that as well? |
|
@nikhiljindal: Done. |
|
And the description? |
|
Done. On Mon, May 4, 2015 at 1:35 PM, Brian Grant notifications@github.com
|
|
LGTM, thanks. |
bgrant0607
added a commit
that referenced
this pull request
May 4, 2015
Explicitly state the lack of support for 'Requests' for the purposes of scheduling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7355