kubelet/container: Update the runtime interface. #7466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @dchen1107 @bakins |
|
LGTM, will wait for green. Thanks @yifan-gu! |
Make some of them (RunInContainer, ExecInContainer, etc) to have same function signatures as current docker and rkt implementation.
|
@vmarmol Update for one more, Which matches the current implementations. |
|
LGTM |
vmarmol
added a commit
that referenced
this pull request
Apr 29, 2015
kubelet/container: Update the runtime interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some of them (RunInContainer, ExecInContainer, etc) to have
same function signatures as current docker and rkt implementation.
Have discussed with @vmarmol last week. Think containerID is fine for now(though we want to have a strong type for the ID).