Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replica: serialize created-by reference #7468

Merged
merged 1 commit into from May 5, 2015

Conversation

simon3z
Copy link
Contributor

@simon3z simon3z commented Apr 28, 2015

/cc @lavalamp

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@simon3z
Copy link
Contributor Author

simon3z commented Apr 28, 2015

@lavalamp this is not fully ready to be merged yet but please check that the general idea is ok. Thanks!

@@ -1583,6 +1583,11 @@ type ObjectReference struct {
FieldPath string `json:"fieldPath,omitempty"`
}

type SerializedReference struct {
TypeMeta `json:",inline"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ObjectMeta

@lavalamp
Copy link
Member

This looks mostly correct, thanks-- just need to follow objectmeta/typemeta conventions-- they differ a little between versions.

@simon3z
Copy link
Contributor Author

simon3z commented Apr 29, 2015

@lavalamp I am just using Kind/APIVersion, I think TypeMeta is the correct one for all the versions. Isn't it?

@lavalamp
Copy link
Member

Ah-- actually I think you might be right. We don't need object meta, since we don't store this as a top level object.

@smarterclayton
Copy link
Contributor

Brian was proposing the dependencies object for this use case, but it doesn't exist yet. That would be a list of object references (or object references with additional data).

@lavalamp
Copy link
Member

lavalamp commented May 4, 2015

LGTM, needs a rebase.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 4, 2015
@simon3z
Copy link
Contributor Author

simon3z commented May 4, 2015

@lavalamp I have no idea why Shippable failed. Anyway I expect travis to pass.

@simon3z
Copy link
Contributor Author

simon3z commented May 5, 2015

@lavalamp ping, can this be merged?

@lavalamp
Copy link
Member

lavalamp commented May 5, 2015

Sorry for delay. We've added the pkg/api/v1 api version, can you add this in there, too?

Fixes kubernetes#7322

Signed-off-by: Federico Simoncelli <fsimonce@redhat.com>
@simon3z
Copy link
Contributor Author

simon3z commented May 5, 2015

@lavalamp can you check if you can merge this today. Thanks.

@lavalamp
Copy link
Member

lavalamp commented May 5, 2015

LGTM

@lavalamp lavalamp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2015
@lavalamp
Copy link
Member

lavalamp commented May 5, 2015

Will merge on green

lavalamp added a commit that referenced this pull request May 5, 2015
replica: serialize created-by reference
@lavalamp lavalamp merged commit 8a47574 into kubernetes:master May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants