New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replica: serialize created-by reference #7468
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@lavalamp this is not fully ready to be merged yet but please check that the general idea is ok. Thanks! |
@@ -1583,6 +1583,11 @@ type ObjectReference struct { | |||
FieldPath string `json:"fieldPath,omitempty"` | |||
} | |||
|
|||
type SerializedReference struct { | |||
TypeMeta `json:",inline"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ObjectMeta
This looks mostly correct, thanks-- just need to follow objectmeta/typemeta conventions-- they differ a little between versions. |
1d232b9
to
075da17
Compare
@lavalamp I am just using Kind/APIVersion, I think TypeMeta is the correct one for all the versions. Isn't it? |
Ah-- actually I think you might be right. We don't need object meta, since we don't store this as a top level object. |
Brian was proposing the dependencies object for this use case, but it doesn't exist yet. That would be a list of object references (or object references with additional data). |
LGTM, needs a rebase. |
075da17
to
6759e85
Compare
CLAs look good, thanks! |
@lavalamp I have no idea why Shippable failed. Anyway I expect travis to pass. |
@lavalamp ping, can this be merged? |
Sorry for delay. We've added the pkg/api/v1 api version, can you add this in there, too? |
Fixes kubernetes#7322 Signed-off-by: Federico Simoncelli <fsimonce@redhat.com>
6759e85
to
37038c4
Compare
@lavalamp can you check if you can merge this today. Thanks. |
LGTM |
Will merge on green |
replica: serialize created-by reference
/cc @lavalamp