New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed kubelet deleting data from volumes on stop (#7317). #7503
Conversation
We must not clear the pod directory in killUnwantedPods(), volumes are still mounted there at this time. There already is cleanupOrphanedPodDirs(), called later in the SyncPods() sequence, which should remove these pod directories.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@jsafrane we want to move to a model where more things are done per-pod and have less of the "orphaned resource" work. Removing this would move against that direction. Do you have a pointer to an issue or can you describe the problem? I am not be understanding where the problem lies :) |
Aaaaah I see what you mean, thanks for the context @childsb! LGTM |
@jsafrane have you had a chance to run the storage-related e2e's? We should consider adding an e2e for this as well. |
I ran e2e with this change and came back clean :) merging, thanks @jsafrane!
|
Fixed kubelet deleting data from volumes on stop (#7317).
We must not clear the pod directory in killUnwantedPods(), volumes are still
mounted there at this time. There already is cleanupOrphanedPodDirs(),
called later in the SyncPods() sequence, which should remove these pod
directories.