Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed kubelet deleting data from volumes on stop (#7317). #7503

Merged
merged 1 commit into from Apr 29, 2015

Conversation

jsafrane
Copy link
Member

We must not clear the pod directory in killUnwantedPods(), volumes are still
mounted there at this time. There already is cleanupOrphanedPodDirs(),
called later in the SyncPods() sequence, which should remove these pod
directories.

We must not clear the pod directory in killUnwantedPods(), volumes are still
mounted there at this time. There already is cleanupOrphanedPodDirs(),
called later in the SyncPods() sequence, which should remove these pod
directories.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@vmarmol
Copy link
Contributor

vmarmol commented Apr 29, 2015

@jsafrane we want to move to a model where more things are done per-pod and have less of the "orphaned resource" work. Removing this would move against that direction. Do you have a pointer to an issue or can you describe the problem? I am not be understanding where the problem lies :)

@childsb
Copy link
Contributor

childsb commented Apr 29, 2015

This bug is currently a showstopper for two of the volume plugins:

#7360
#7317

@vmarmol
Copy link
Contributor

vmarmol commented Apr 29, 2015

Aaaaah I see what you mean, thanks for the context @childsb! LGTM

@vmarmol
Copy link
Contributor

vmarmol commented Apr 29, 2015

@jsafrane have you had a chance to run the storage-related e2e's?

We should consider adding an e2e for this as well.

@vmarmol
Copy link
Contributor

vmarmol commented Apr 29, 2015

I ran e2e with this change and came back clean :) merging, thanks @jsafrane!

Ran 36 of 41 Specs in 1126.593 seconds
SUCCESS! -- 36 Passed | 0 Failed | 1 Pending | 4 Skipped I0429 09:58:54.840736    7378 driver.go:96] All tests pass

vmarmol added a commit that referenced this pull request Apr 29, 2015
Fixed kubelet deleting data from volumes on stop (#7317).
@vmarmol vmarmol merged commit 02231ea into kubernetes:master Apr 29, 2015
@ghost ghost mentioned this pull request May 15, 2015
@jsafrane jsafrane deleted the devel/fix-volume-rm branch August 19, 2016 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants