Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cobra rebase #7510

Merged
merged 3 commits into from Apr 29, 2015
Merged

Cobra rebase #7510

merged 3 commits into from Apr 29, 2015

Conversation

eparis
Copy link
Contributor

@eparis eparis commented Apr 29, 2015

Redo the flag word separator stuff with a generic function. It still works.

_output/local/go/bin/kube-apiserver --portal_net=10.10.10.10/30 --etcd.servers=10.10.10.10

is valid.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@j3ffml
Copy link
Contributor

j3ffml commented Apr 29, 2015

LGTM.

@eparis
Copy link
Contributor Author

eparis commented Apr 29, 2015

I signed it!

j3ffml added a commit that referenced this pull request Apr 29, 2015
@j3ffml j3ffml merged commit 9fd8cba into kubernetes:master Apr 29, 2015
@eparis eparis deleted the cobra-rebase branch August 4, 2015 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants