Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose URL() on Request to allow building URLs #7546

Merged
merged 1 commit into from Apr 30, 2015

Conversation

smarterclayton
Copy link
Contributor

The client/Request type is the appropriate place to build
URLs, this allows callers to generate URLs for providing to
others (such as SelfLinks or relative links to objects).

The client/Request type is the appropriate place to build
URLs, this allows callers to generate URLs for providing to
others (such as SelfLinks or relative links to objects).
@wojtek-t
Copy link
Member

LGTM

@wojtek-t wojtek-t added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2015
@wojtek-t wojtek-t assigned wojtek-t and unassigned nikhiljindal Apr 30, 2015
wojtek-t added a commit that referenced this pull request Apr 30, 2015
Expose URL() on Request to allow building URLs
@wojtek-t wojtek-t merged commit 6d00e33 into kubernetes:master Apr 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants