WIP: Add startup code to apiserver to migrate etcd keys #7567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcullen
changed the title
|
LGTM, assuming a manual migration test succeeded for you. |
|
I'm out next week. Unassigning myself so that someone else can be assigned to merge it. I'm just waiting for confirmation that it was tested in some suitable way. |
|
Thanks @erictune, I'm working on an integration test for this. |
kbeecher
force-pushed
the
kbeecher/wip_etcd_migrate_keys
branch
2 times, most recently
from
679be84
to
822e25f
Compare
kbeecher
force-pushed
the
kbeecher/wip_etcd_migrate_keys
branch
from
822e25f
to
0473f65
Compare
|
Done. |
|
Merging this on @erictune 's LGTM and a passing integration test. |
brendandburns
added a commit
that referenced
this pull request
May 7, 2015
WIP: Add startup code to apiserver to migrate etcd keys
|
I think this was the wrong approach to solving this problem, filed #8192. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@erictune mentioned in #3476 that, as part of the work adding a custom etcd prefix, we should also add a flag to tell the apiserver what old, possibly empty prefix, to copy old data from. In the apiserver startup code the etcd keys should be migrated those flags.
I played around with some migration code and thought I would share it with you in a WIP branch to see if this is the general way it should go.
Would be grateful for any comments.
Refs: #3476