Select IPv4-only from host interfaces #7721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| break | ||
| for _, addr := range addrs { | ||
| if addrIP, _, err := net.ParseCIDR(addr.String()); err == nil { | ||
| if addrIP.To4() != nil { |
There was a problem hiding this comment.
minor nit: Any reason not to collapse the not nil check and the assignment into a single if statement? i.e. single call to To4().
There was a problem hiding this comment.
Long if line is probably the reason. Agree the nesting is really high.
|
Other than the two nits, LGTM. |
ghost
pushed a commit
that referenced
this pull request
May 4, 2015
Select IPv4-only from host interfaces
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On other platforms, ChooseHostInterfaces() is returning IPv6
addresses, which the master can't use (endpoints must be IPv4)
Fixes #7716