Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet/rkt: Add docker prefix to image string. #7803

Merged
merged 1 commit into from May 6, 2015

Conversation

yifan-gu
Copy link
Contributor

@yifan-gu yifan-gu commented May 5, 2015

This change makes rkt to run only docker image for now,
which enables us to test with all existing pods.

@vmarmol vmarmol self-assigned this May 5, 2015
@vmarmol
Copy link
Contributor

vmarmol commented May 5, 2015

@yifan-gu can rebase now that the dep is in.

@vmarmol
Copy link
Contributor

vmarmol commented May 5, 2015

LGTM

This change makes rkt to run only docker image for now,
which enables us to test with all existing pods.
@yifan-gu
Copy link
Contributor Author

yifan-gu commented May 5, 2015

@vmarmol Thanks, rebased!

@vmarmol vmarmol added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2015
jszczepkowski added a commit that referenced this pull request May 6, 2015
kubelet/rkt: Add docker prefix to image string.
@jszczepkowski jszczepkowski merged commit 4d655e3 into kubernetes:master May 6, 2015
@yifan-gu yifan-gu deleted the rkt_docker_image branch May 7, 2015 17:28
@soltysh soltysh mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants