Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update logging-demo to use API v1beta3; modify the way to access Elasticsearch and Kibana services #7824

Merged
merged 1 commit into from May 6, 2015

Conversation

caesarxuchao
Copy link
Member

update logging-demo to use API v1beta3; modify the way to access Elasticsearch and Kibana services.

Fixes #7818.

…ticsearch and Kibana services

    COMMIT_BLOCKED_ON_GENDOCS
@caesarxuchao
Copy link
Member Author

@nikhiljindal @mbforbes

@mbforbes
Copy link
Contributor

mbforbes commented May 6, 2015

@satnam6502 what do you think?

@satnam6502
Copy link
Contributor

The reason I have not updated this yet is that I am furiously working away on the logging blog article and in the process making a lot of changes to our logging setup and examples. We could merge this -- but the changes would be short lived since they are likely to be eclipsed by my work in progress.

@satnam6502 satnam6502 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2015
@satnam6502
Copy link
Contributor

Thank you very much for your help.

@caesarxuchao
Copy link
Member Author

No problem : )

@mbforbes
Copy link
Contributor

mbforbes commented May 6, 2015

@satnam6502 shall I merge this in for the interim until your overhaul is complete?

satnam6502 added a commit that referenced this pull request May 6, 2015
update logging-demo to use API v1beta3; modify the way to access Elasticsearch and Kibana services
@satnam6502 satnam6502 merged commit 9939f92 into kubernetes:master May 6, 2015
@caesarxuchao caesarxuchao deleted the Kibana-example branch May 12, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing public IP in examples/logging-demo
4 participants