Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples/meteor to use API v1beta3 #7848

Merged
merged 1 commit into from May 7, 2015
Merged

Update examples/meteor to use API v1beta3 #7848

merged 1 commit into from May 7, 2015

Conversation

caesarxuchao
Copy link
Member

@chees @nikhiljindal

  • I have updated the json files. I have verified that these json files can create service/pod/replicationcontroller correctly. But I don't know how to check if meteor is running correctly. Can some one verify?
  • I change the way to get the external IP of the meteor service. Now it uses kubectl instead of the gcloud specific command.

nikhiljindal
nikhiljindal reviewed May 6, 2015
View reviewed changes
examples/meteor/README.md

gcloud compute forwarding-rules list k8s-meteor-default-meteor | grep k8s-meteor-default-meteor | awk '{print $3}'
kubectl get services/meteor -o yaml | awk '/publicIPs/{getline; print $2}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about: kubectl get services/meteor -o template -t "{{.spec.publicIPs}}"? It seems cleaner.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Using template exposes more kubectl features.

@nikhiljindal
Copy link
Contributor

LGTM modulo one comment.

@nikhiljindal
Copy link
Contributor

LGTM.
As per https://github.com/Q42/meteor-gke-example/blob/master/README.md, you can verify if it is working fine by verifying that it "prints the public IP address of the machine the app is running on"?

@chees
Copy link
Contributor

chees commented May 7, 2015

I verified that following these steps with the v1beta3 api works.

However, at first it took a long time before Mongo was not "pending" anymore and running gcloud alpha container kubectl describe pod mongo showed:

Thu, 07 May 2015 11:24:50 +0200 Thu, 07 May 2015 11:24:50 +0200 1 {kubelet k8s-cluster-2-node-1}            failedMount Unable to mount volumes for pod "mongo_default": Could not attach disk: Timeout after 10s
Thu, 07 May 2015 11:24:50 +0200 Thu, 07 May 2015 11:24:50 +0200 1 {kubelet k8s-cluster-2-node-1}            failedSync  Error syncing pod, skipping: Could not attach disk: Timeout after 10s

Not sure if that's related to this change. After a while the problem fixed itself and mongo came up anyway, so I guess it's not a serious problem.

@nikhiljindal
Copy link
Contributor

Great. Will merge then

nikhiljindal added a commit that referenced this pull request May 7, 2015
@nikhiljindal
Merge pull request #7848 from caesarxuchao/meteor-example
a1c305c 
Update examples/meteor to use API v1beta3
@nikhiljindal nikhiljindal merged commit a1c305c into kubernetes:master May 7, 2015
@jeffmendoza jeffmendoza mentioned this pull request May 7, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhiljindal nikhiljindal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@caesarxuchao @nikhiljindal @chees @googlebot