Ignore latency metrics for events #7857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #7561 |
| metrics, err := ReadLatencyMetrics(c) | ||
| if err != nil { | ||
| return 0, err | ||
| } | ||
| ignored := make(map[string]bool) | ||
| for _, resource := range ignoredResources { |
There was a problem hiding this comment.
suggest declaring this as a util.StringSet and checking the set with Has, instead of a list that becomes a dict
|
LGTM with one nit |
fgrzadkowski
force-pushed
the
fix_jenkins
branch
2 times, most recently
from
88b934e
to
a1a61d9
Compare
wojtek-t
added
the
lgtm
|
LGTM - will merge on green. |
wojtek-t
added a commit
that referenced
this pull request
May 7, 2015
Ignore latency metrics for events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some of the jenkins failure.
@wojtek-t @bprashanth @quinton-hoole