kubelet/rkt: Remove dependencies on rkt.store #7859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good overall and easier solution than most others! Thanks @yifan-gu! |
Replace getImageID() with getImageByName(), this can remove the dependency on rkt.store.
|
@vmarmol Nit addressed! |
|
LGTM, merging. |
vmarmol
added a commit
that referenced
this pull request
May 7, 2015
kubelet/rkt: Remove dependencies on rkt.store
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st commit change getImageID() and remove the code that uses store.
2nd commit update the godep by removing the rkt.store package.
This could probably fix #7850
/cc @vmarmol @dchen1107 @yujuhong