Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet: Add container runtime option for rkt. #7900

Merged
merged 1 commit into from May 7, 2015

Conversation

yifan-gu
Copy link
Contributor

@yifan-gu yifan-gu commented May 7, 2015

Second take after #7743 since the glibc problem should be gone now by #7859

/cc @vmarmol @dchen1107 @yujuhong

@dchen1107 dchen1107 self-assigned this May 7, 2015
@dchen1107
Copy link
Member

LGTM.

@dchen1107 dchen1107 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2015
@vmarmol
Copy link
Contributor

vmarmol commented May 7, 2015

LGTM :)

vmarmol added a commit that referenced this pull request May 7, 2015
kubelet: Add container runtime option for rkt.
@vmarmol vmarmol merged commit 3d0f54f into kubernetes:master May 7, 2015
@yifan-gu yifan-gu deleted the rkt_switch branch May 7, 2015 19:33
@ixdy
Copy link
Member

ixdy commented May 7, 2015

This PR broke non-Linux builds:

+++ [0507 19:52:01] linux/amd64: go build started
+++ [0507 19:52:23] linux/amd64: go build finished
+++ [0507 19:52:01] linux/386: go build started
+++ [0507 19:52:28] linux/386: go build finished
+++ [0507 19:52:01] linux/arm: go build started
+++ [0507 19:52:27] linux/arm: go build finished
+++ [0507 19:52:01] darwin/amd64: go build started
# github.com/GoogleCloudPlatform/kubernetes/pkg/kubelet/rkt
_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/kubelet/rkt/gc.go:21: undefined: runtime
!!! Error in /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:341
  'go install "${goflags[@]:+${goflags[@]}}" -ldflags "${version_ldflags}" "${nonstatics[@]:+${nonstatics[@]}}"' exited with status 2
Call stack:
  1: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:341 kube::golang::build_binaries_for_platform(...)
  2: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:447 kube::golang::build_binaries(...)
  3: hack/build-cross.sh:31 main(...)
Exiting with status 1
+++ [0507 19:52:01] darwin/386: go build started
# github.com/GoogleCloudPlatform/kubernetes/pkg/kubelet/rkt
_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/kubelet/rkt/gc.go:21: undefined: runtime
!!! Error in /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:341
  'go install "${goflags[@]:+${goflags[@]}}" -ldflags "${version_ldflags}" "${nonstatics[@]:+${nonstatics[@]}}"' exited with status 2
Call stack:
  1: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:341 kube::golang::build_binaries_for_platform(...)
  2: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:447 kube::golang::build_binaries(...)
  3: hack/build-cross.sh:31 main(...)
Exiting with status 1
+++ [0507 19:52:01] windows/amd64: go build started
# github.com/GoogleCloudPlatform/kubernetes/pkg/kubelet/rkt
_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/kubelet/rkt/gc.go:21: undefined: runtime
!!! Error in /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:341
  'go install "${goflags[@]:+${goflags[@]}}" -ldflags "${version_ldflags}" "${nonstatics[@]:+${nonstatics[@]}}"' exited with status 2
Call stack:
  1: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:341 kube::golang::build_binaries_for_platform(...)
  2: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:447 kube::golang::build_binaries(...)
  3: hack/build-cross.sh:31 main(...)
Exiting with status 1
!!! Error in /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:384
  '( kube::golang::setup_env; local version_ldflags; version_ldflags=$(kube::version::ldflags); local host_platform; host_platform=$(kube::golang::host_platform); local goflags; eval "goflags=(${KUBE_GOFLAGS:-})"; local use_go_build; local -a targets=(); local arg; for arg in "$@";
do
    if [[ "${arg}" == "--use_go_build" ]]; then
        use_go_build=true;
    else
        if [[ "${arg}" == -* ]]; then
            goflags+=("${arg}");
        else
            targets+=("${arg}");
        fi;
    fi;
done; if [[ ${#targets[@]} -eq 0 ]]; then
    targets=("${KUBE_ALL_TARGETS[@]}");
fi; local -a platforms=("${KUBE_BUILD_PLATFORMS[@]:+${KUBE_BUILD_PLATFORMS[@]}}"); if [[ ${#platforms[@]} -eq 0 ]]; then
    platforms=("${host_platform}");
fi; local binaries; binaries=($(kube::golang::binaries_from_targets "${targets[@]}")); local parallel=false; if [[ ${#platforms[@]} -gt 1 ]]; then
    local gigs; gigs=$(kube::golang::get_physmem); if [[ ${gigs} -gt ${KUBE_PARALLEL_BUILD_MEMORY} ]]; then
        kube::log::status "Multiple platforms requested and available ${gigs}G > threshold ${KUBE_PARALLEL_BUILD_MEMORY}G, building platforms in parallel"; parallel=true;
    else
        kube::log::status "Multiple platforms requested, but available ${gigs}G < threshold ${KUBE_PARALLEL_BUILD_MEMORY}G, building platforms in serial"; parallel=false;
    fi;
fi; if [[ "${parallel}" == "true" ]]; then
    kube::log::status "Building go targets for ${platforms[@]} in parallel (output will appear in a burst when complete):" "${targets[@]}"; local platform; for platform in "${platforms[@]}";
    do
        ( kube::golang::set_platform_envs "${platform}"; kube::log::status "${platform}: go build started"; kube::golang::build_binaries_for_platform ${platform} ${use_go_build:-}; kube::log::status "${platform}: go build finished" ) &> "/tmp//${platform//\//_}.build" &
    done; local fails=0; for job in $(jobs -p);
    do
        wait ${job} || let "fails+=1";
    done; for platform in "${platforms[@]}";
    do
        cat "/tmp//${platform//\//_}.build";
    done; exit ${fails};
else
    for platform in "${platforms[@]}";
    do
        kube::log::status "Building go targets for ${platform}:" "${targets[@]}"; kube::golang::set_platform_envs "${platform}"; kube::golang::build_binaries_for_platform ${platform} ${use_go_build:-};
    done;
fi )' exited with status 3
Call stack:
  1: /go/src/github.com/GoogleCloudPlatform/kubernetes/hack/lib/golang.sh:384 kube::golang::build_binaries(...)
  2: hack/build-cross.sh:31 main(...)
Exiting with status 1
!!! Error in /jenkins-master-data/jobs/kubernetes-build/workspace/hack/e2e-internal/../../cluster/gce/../../cluster/../build/../build/common.sh:433
  '"${docker_cmd[@]}" "$@"' exited with status 1
Call stack:
  1: /jenkins-master-data/jobs/kubernetes-build/workspace/hack/e2e-internal/../../cluster/gce/../../cluster/../build/../build/common.sh:433 kube::build::run_build_command(...)
  2: /jenkins-master-data/jobs/kubernetes-build/workspace/hack/e2e-internal/../../cluster/gce/../../cluster/../build/release.sh:32 main(...)
Exiting with status 1

@vmarmol
Copy link
Contributor

vmarmol commented May 7, 2015

Reverted and will try again. We still need the stubs for these cases.

@yifan-gu
Copy link
Contributor Author

yifan-gu commented May 7, 2015

I think we can remove the build label

@yifan-gu yifan-gu restored the rkt_switch branch May 7, 2015 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants