Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop setting a GKE specific version of the kubeconfig file #7921

Merged
merged 1 commit into from May 9, 2015
Merged

Stop setting a GKE specific version of the kubeconfig file #7921

merged 1 commit into from May 9, 2015

Conversation

roberthbailey
Copy link
Contributor

Now that the latest gcloud has been released which uses the canonical location.

/cc @jlowdermilk

@j3ffml
Copy link
Contributor

j3ffml commented May 7, 2015

Need to wait on this one. The cloudsdk release for this week was held back.
On May 7, 2015 2:30 PM, "Robert Bailey" notifications@github.com wrote:

Now that the latest gcloud has been released which uses the canonical
location.

/cc @jlowdermilk https://github.com/jlowdermilk

You can view, comment on, or merge this pull request online at:

#7921
Commit Summary

  • Stop setting a GKE specific version of the kubeconfig file now that

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#7921.

@roberthbailey
Copy link
Contributor Author

Really? Mine got updated today around noon.

@roberthbailey
Copy link
Contributor Author

I just did another update and went backwards to the prior release (from 0.9.59 -> 0.9.58).

@roberthbailey
For GKE, only use the special kubeconfig location if the file exists.
9db0c68 
This will allow Jenkins to keep running after the next gcloud release
without needing to make immediate modifications to this file. We can
then remove the extra logic at our own convenience.
@roberthbailey
Copy link
Contributor Author

Re-pushed with some conditional logic that should allow us to transparently pick up the new gcloud release in jenkins. Once the release is out we should rip out the extra checks and just always use the global kubeconfig location.

@j3ffml
Copy link
Contributor

j3ffml commented May 8, 2015

lgtm

@j3ffml j3ffml added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2015
j3ffml added a commit that referenced this pull request May 9, 2015
@j3ffml
Merge pull request #7921 from roberthbailey/gke-kubeconfig
051288c 
Stop setting a GKE specific version of the kubeconfig file
@j3ffml j3ffml merged commit 051288c into kubernetes:master May 9, 2015
j3ffml added a commit to j3ffml/kubernetes that referenced this pull request May 9, 2015
@j3ffml
fix kubernetes#7921
78386e4
j3ffml added a commit that referenced this pull request May 9, 2015
@j3ffml
Merge pull request #8017 from jlowdermilk/fix-gke-ci
c2171e8 
fix #7921
@j3ffml j3ffml mentioned this pull request May 11, 2015
Merged
@roberthbailey roberthbailey deleted the gke-kubeconfig branch August 20, 2015 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roberthbailey @j3ffml @googlebot