update example/walkthrough to v1beta3 #7940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ``` | ||
|
|
||
| Ok, so what did we do? We added a volume to our pod: | ||
|
|
||
| Ok, so what did we do? We added a volume of our pod: |
There was a problem hiding this comment.
Adding a volume "to" pod seems better than volume "of" pod
|
LGTM, modulo a few nits. You should also update the PR title to something more appropriate like "Updating examples/walkthrough to use v1beta3 configs" |
caesarxuchao
force-pushed
the
walkthrough-example
branch
from
a6ffec4
to
e20adfd
Compare
|
@nikhiljindal, thanks. |
caesarxuchao
changed the title
caesarxuchao
force-pushed
the
walkthrough-example
branch
from
e20adfd
to
ab356c9
Compare
|
Shippable is still red. |
|
@nikhiljindal Do you know why the first build failed but the second on was successful? |
|
I didn't change anything but shippable is green now |
|
It had timedout last time. I restarted it and it is green now. |
nikhiljindal
added a commit
that referenced
this pull request
May 11, 2015
update example/walkthrough to v1beta3
| # an http probe | ||
| httpGet: | ||
| path: /_status/healthz | ||
| port: 8080 |
There was a problem hiding this comment.
Doesn't match the exposed containerPort (80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified that all the v1beta3 yaml files are working properly @nikhiljindal