Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the first token uname -n as the hostname #7967

Merged
merged 1 commit into from May 8, 2015

Conversation

yujuhong
Copy link
Contributor

@yujuhong yujuhong commented May 8, 2015

This change partially reverts the change made in #7910, which takes only the
first token of uname -n as the hostname.

This change partially reverts the change made in kubernetes#7910, which takes only the
first token of `uname -n` as the hostname.
@vmarmol vmarmol self-assigned this May 8, 2015
@vmarmol
Copy link
Contributor

vmarmol commented May 8, 2015

LGTM, thanks for the quick fix @yujuhong!

@yujuhong
Copy link
Contributor Author

yujuhong commented May 8, 2015

/cc @timothysc, this should fix the breakage in your cluster. FYI, in #6499, we discussed whether it's sensible to use only the first token of the FQDN as a unique hostname, and most people were okay with it. Is it not true in your case?

@timothysc
Copy link
Member

It should default the node checkin to fqdn, we have our setup explicitly set to check as there are many theifdoms , e.g. bob.redhat.com, bob.test.redhat.com, bob.prod.redhat.com

/cc @rrati @eparis @jayunit100

@dchen1107
Copy link
Member

@yujuhong What is the problem we are fixing here?

#7072 along with other prs from different cloud provider owners removed fqdn dependencies from a node name.

@vmarmol
Copy link
Contributor

vmarmol commented May 8, 2015

@dchen1107 @timothysc was running into issues with our latest change. We changed all uses of the hostname to be the first section, this may not be unique in all settings.

@yujuhong
Copy link
Contributor Author

yujuhong commented May 8, 2015

@dchen1107, if I understand correctly, @timothysc's cluster uses FQDNs (probably through uname -n?) as the hostnames of the node. The first sections of the these FQDNs are not unique, leading conflicts after #7910 was merged.

@timothysc
Copy link
Member

@yujuhong correct.

@timothysc
Copy link
Member

LGTM, are we waiting on something?

@vmarmol
Copy link
Contributor

vmarmol commented May 8, 2015

Merging to fix breakage, we can discuss more here or in an issue :)

vmarmol added a commit that referenced this pull request May 8, 2015
Don't use the first token `uname -n` as the hostname
@vmarmol vmarmol merged commit 2c0a047 into kubernetes:master May 8, 2015
@yujuhong yujuhong deleted the uname_n branch May 18, 2015 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants