New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use the first token uname -n
as the hostname
#7967
Conversation
This change partially reverts the change made in kubernetes#7910, which takes only the first token of `uname -n` as the hostname.
LGTM, thanks for the quick fix @yujuhong! |
/cc @timothysc, this should fix the breakage in your cluster. FYI, in #6499, we discussed whether it's sensible to use only the first token of the FQDN as a unique hostname, and most people were okay with it. Is it not true in your case? |
It should default the node checkin to fqdn, we have our setup explicitly set to check as there are many theifdoms , e.g. bob.redhat.com, bob.test.redhat.com, bob.prod.redhat.com /cc @rrati @eparis @jayunit100 |
@dchen1107 @timothysc was running into issues with our latest change. We changed all uses of the hostname to be the first section, this may not be unique in all settings. |
@dchen1107, if I understand correctly, @timothysc's cluster uses FQDNs (probably through |
@yujuhong correct. |
LGTM, are we waiting on something? |
Merging to fix breakage, we can discuss more here or in an issue :) |
Don't use the first token `uname -n` as the hostname
This change partially reverts the change made in #7910, which takes only the
first token of
uname -n
as the hostname.