make the dockerkeyring handle mutiple matching credentials #7971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deads2k
force-pushed
the
make-docker-keyring-handle-multiple-hits
branch
from
6cb0318
to
9e2e79a
Compare
deads2k
force-pushed
the
make-docker-keyring-handle-multiple-hits
branch
from
9e2e79a
to
2ecb0eb
Compare
|
Looks ok to me, would want someone who has been in here more recently than me to sign off. |
|
LGTM. Merging. |
brendandburns
added a commit
that referenced
this pull request
May 12, 2015
…iple-hits make the dockerkeyring handle mutiple matching credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of #7894.
This makes the docker keyring and the puller properly handle multiple potentially valid credentials for a given image.
@brendandburns ptal