eliminate auth-path #8064
Merged
eliminate auth-path #8064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Will be nice to get rid of this. |
|
shippable green. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates auth-path from everything except the kubelet. I've split it into two commits:
--auth-pathon the command line and removes documentation about it.auth-pathfrom kubeconfig files. This commit might break kubeconfig files that existed before we stopped generating kubeconfig files. The number of those should be relatively limited, but I made it separate in case you considered that too much. BecauseAuthPathreferences an external file and because it affects both the user stanza and an unknown(!) cluster stanza, we can't build a reasonable conversion.Final part of #3800.
My e2e is still running, but I don't anticipate any problems since there aren't references to
auth-path.@jlowdermilk ptal