Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeating alert conditions do not respect grace period #3579

Closed
edmundoa opened this issue Mar 6, 2017 · 0 comments
Closed

Repeating alert conditions do not respect grace period #3579

edmundoa opened this issue Mar 6, 2017 · 0 comments
Assignees
@edmundoa
Labels
bug triaged
Milestone
2.2.3

Comments

@edmundoa
Copy link
Contributor

edmundoa commented Mar 6, 2017

From the Graylog Community: https://community.graylog.org/t/alerts-repeats-notifications-every-minutes/344

Expected Behaviour

Setting up an alert condition with repeated notifications should respect the grace period before notifying again, even if the alert is in an unresolved state. Otherwise the behaviour is not the same as in versions prior to 2.2.

Current Behaviour

Alert conditions with the repeat notification flag on respect grace period only after the alert is marked as resolved. That means that users will get notified on every check regardless of the grace period.

Steps to Reproduce (for bugs)

  1. Set up an alert condition, check the repeat notification checkbox, and set some grace period
  2. Wait until the alert fires
  3. See that you get notified on every check, regardless of the grace period setting

Your Environment

  • Graylog Version: 2.2.2
@edmundoa edmundoa added the bug label Mar 6, 2017
@jalogisch jalogisch added this to the 2.2.3 milestone Mar 14, 2017
@edmundoa edmundoa assigned edmundoa and unassigned kroepke Mar 29, 2017
edmundoa pushed a commit that referenced this issue Mar 31, 2017
Comply with grace period when repeating notifications
3914a86 
Check the time last notification was sent to ensure we don't repeat
notifications too often, complying with the grace period set by the
user.

Fixes #3579
@edmundoa edmundoa mentioned this issue Mar 31, 2017
Merged
@ghost ghost removed the in progress label Apr 3, 2017
dennisoelkers pushed a commit that referenced this issue Apr 3, 2017
@edmundoa @dennisoelkers
Comply with grace condition when repeat alert notifications is enabled (
260bc95 
#3676)

* Remove condition, as it's always true

* Comply with grace period when repeating notifications

Check the time last notification was sent to ensure we don't repeat
notifications too often, complying with the grace period set by the
user.

Fixes #3579

* Fix ForbiddenAPIs errors

* Mock shouldRepeatNotifications method to fix test
edmundoa added a commit that referenced this issue Apr 3, 2017
@edmundoa
Comply with grace condition when repeat alert notifications is enabled (
1d3cea4 
#3676)

* Remove condition, as it's always true

* Comply with grace period when repeating notifications

Check the time last notification was sent to ensure we don't repeat
notifications too often, complying with the grace period set by the
user.

Fixes #3579

* Fix ForbiddenAPIs errors

* Mock shouldRepeatNotifications method to fix test
@edmundoa edmundoa mentioned this issue Apr 3, 2017
Merged
dennisoelkers pushed a commit that referenced this issue Apr 3, 2017
@edmundoa @dennisoelkers
Comply with grace condition when repeat alert notifications is enabled (
9f3db75 
#3676) (#3686)

* Remove condition, as it's always true

* Comply with grace period when repeating notifications

Check the time last notification was sent to ensure we don't repeat
notifications too often, complying with the grace period set by the
user.

Fixes #3579

* Fix ForbiddenAPIs errors

* Mock shouldRepeatNotifications method to fix test
@edmundoa edmundoa mentioned this issue Apr 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edmundoa edmundoa

Labels
bug triaged
Projects
None yet
Milestone
2.2.3
Development

No branches or pull requests
3 participants
@kroepke @jalogisch @edmundoa