Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] CMake: add prefix "SRT" to all srt cmake options #2914

Open
IvanPysmenni opened this issue Mar 12, 2024 · 0 comments
Open

[FR] CMake: add prefix "SRT" to all srt cmake options #2914

IvanPysmenni opened this issue Mar 12, 2024 · 0 comments
Labels
[build] Area: Changes in build files help wanted Indicates that a maintainer wants help on an issue or pull request Type: Enhancement Indicates new feature requests
Milestone

Comments

@IvanPysmenni
Copy link

There is an inconvenience with configuration srt lib build in a case when srt was added to CMake project as subdirectory. SRT options doesn't have an unique name. So during configuration in root CMake file there is a chance that this name is already used by another project in your build(for example ENABLE_APPS). It would be to add prefix "SRT" to all srt cmake options. For example: SRT_ENABLE_APPS.

As an example this is how it is done in spdlog:
https://github.com/gabime/spdlog/blob/v1.x/CMakeLists.txt#L59

@IvanPysmenni IvanPysmenni added the Type: Enhancement Indicates new feature requests label Mar 12, 2024
@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Jun 13, 2024
@maxsharabayko maxsharabayko added [build] Area: Changes in build files help wanted Indicates that a maintainer wants help on an issue or pull request labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[build] Area: Changes in build files help wanted Indicates that a maintainer wants help on an issue or pull request Type: Enhancement Indicates new feature requests
Projects
None yet
Development

No branches or pull requests

2 participants